linux-ext4 - Re: [PATCH 20/32] ext4: improve journal credit handling in set xattr paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622023021.qfwvdb53hg6butan@thunk.org>
Date:   Wed, 21 Jun 2017 22:30:21 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/32] ext4: improve journal credit handling in set xattr
 paths

On Wed, Jun 21, 2017 at 02:21:30PM -0700, Tahsin Erdogan wrote:
> Both ext4_set_acl() and ext4_set_context() need to be made aware of
> ea_inode feature when it comes to credits calculation.
> 
> Also add a sufficient credits check in ext4_xattr_set_handle() right
> after xattr write lock is grabbed. Original credits calculation is done
> outside the lock so there is a possiblity that the initially calculated
> credits are not sufficient anymore.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, applied.

					- Ted