lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170622155236.ncjwgdhlhwd5mssg@thunk.org> Date: Thu, 22 Jun 2017 11:52:36 -0400 From: Theodore Ts'o <tytso@....edu> To: Tahsin Erdogan <tahsin@...gle.com> Cc: Andreas Dilger <adilger@...ger.ca>, "Darrick J . Wong" <darrick.wong@...cle.com>, Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 30/32] ext4: eliminate xattr entry e_hash recalculation for removes On Wed, Jun 21, 2017 at 06:49:37PM -0700, Tahsin Erdogan wrote: > When an extended attribute block is modified, ext4_xattr_hash_entry() > recalculates e_hash for the entry that is pointed by s->here. This is > unnecessary if the modification is to remove an entry. > > Currently, if the removed entry is the last one and there are other > entries remaining, hash calculation targets the just erased entry which > has been filled with zeroes and effectively does nothing. If the removed > entry is not the last one and there are more entries, this time it will > recalculate hash on the next entry which is totally unnecessary. > > Fix these by moving the decision on when to recalculate hash to > ext4_xattr_set_entry(). > > Signed-off-by: Tahsin Erdogan <tahsin@...gle.com> Thanks, applied. - Ted
Powered by blists - more mailing lists