linux-ext4 - Re: [PATCH 08/32] ext4: fix ref counting for ea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622014040.bse3rxjn3cnrxifh@thunk.org>
Date:   Wed, 21 Jun 2017 21:40:40 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/32] ext4: fix ref counting for ea_inode

On Wed, Jun 21, 2017 at 02:21:18PM -0700, Tahsin Erdogan wrote:
> The ref count on ea_inode is incremented by
> ext4_xattr_inode_orphan_add() which is supposed to be decremented by
> ext4_xattr_inode_array_free(). The decrement is conditioned on whether
> the ea_inode is currently on the orphan list. However, the orphan list
> addition only happens when journaling is enabled. In non-journaled case,r
> we fail to release the ref count causing an error message like below.
> 
> "VFS: Busy inodes after unmount of sdb. Self-destruct in 5 seconds.
> Have a nice day..."
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, applied.

					- Ted