lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170623121426.3e7sivaip6izvz5c@thunk.org> Date: Fri, 23 Jun 2017 08:14:26 -0400 From: Theodore Ts'o <tytso@....edu> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] ext4: fix reserved_clusters_store() On Fri, Jun 23, 2017 at 12:28:00PM +0300, Dan Carpenter wrote: > The test if kstrtoull() failed is reversed so we can't set cluster_store > any more. > > Fixes: 76d33bca5581 ("ext4: refactor sysfs support code") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Thanks, this should already be fixed in the ext4.git tree. - Ted commit f5b877c913026b9c5d4d1ac2916eff46c49b37a0 Author: Chao Yu <yuchao0@...wei.com> Date: Fri Jun 23 01:08:22 2017 -0400 ext4: check return value of kstrtoull correctly in reserved_clusters_store kstrtoull returns 0 on success, however, in reserved_clusters_store we will return -EINVAL if kstrtoull returns 0, it makes us fail to update reserved_clusters value through sysfs. Fixes: 76d33bca5581b1dd5c3157fa168db849a784ada4 Cc: stable@...r.kernel.org # 4.4 Signed-off-by: Chao Yu <yuchao0@...wei.com> Signed-off-by: Miao Xie <miaoxie@...wei.com> Signed-off-by: Theodore Ts'o <tytso@....edu> diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c index d74dc5f81a04..48c7a7d55ed3 100644 --- a/fs/ext4/sysfs.c +++ b/fs/ext4/sysfs.c @@ -100,7 +100,7 @@ static ssize_t reserved_clusters_store(struct ext4_attr *a, int ret; ret = kstrtoull(skip_spaces(buf), 0, &val); - if (!ret || val >= clusters) + if (ret || val >= clusters) return -EINVAL; atomic64_set(&sbi->s_resv_clusters, val);
Powered by blists - more mailing lists