lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAeU0aOQF=g7zAP5gtOb0ur-zN-crsHTWNbTYJJZvVJa+JoB_w@mail.gmail.com> Date: Mon, 26 Jun 2017 12:22:02 -0700 From: Tahsin Erdogan <tahsin@...gle.com> To: "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger@...ger.ca>, Khazhismel Kumykov <khazhy@...gle.com>, linux-ext4 <linux-ext4@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry On Thu, Jun 22, 2017 at 4:23 PM, Khazhismel Kumykov <khazhy@...gle.com> wrote: > - /* read error, skip block & hope for the best */ > EXT4_ERROR_INODE(dir, "reading directory lblock %lu", > (unsigned long) block); > brelse(bh); > - goto next; > + ret = ERR_PTR(-EIO); > + goto cleanup_and_exit; EXT4_ERROR_INODE() triggers ext4_handle_error() which performs error handling. I think it should be removed here because we are returning the error to the caller and there is nothing more drastic about this error than other error return paths in the same function.
Powered by blists - more mailing lists