linux-ext4 - Re: [PATCH 04/12] e2fsck: do not early terminate extra space check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CF22DC39-678F-420D-BD6D-28C90CB7D6E3@dilger.ca>
Date:   Mon, 26 Jun 2017 15:23:52 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     "Darrick J . Wong" <darrick.wong@...cle.com>,
        Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 04/12] e2fsck: do not early terminate extra space check


> On Jun 26, 2017, at 7:43 AM, Tahsin Erdogan <tahsin@...gle.com> wrote:
> 
> When check_inode_extra_space() detects a problem with the value of
> i_extra_isize, it adjusts it and then returns without further validation
> of contents in the inode body. Change this so that it will proceed to
> check inline extended attributes.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>
> ---
> e2fsck/pass1.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
> index 32152f3ec926..1532fd2067f2 100644
> --- a/e2fsck/pass1.c
> +++ b/e2fsck/pass1.c
> @@ -582,7 +582,6 @@ static void check_inode_extra_space(e2fsck_t ctx, struct problem_context *pctx)
> 			inode->i_extra_isize = (inode->i_extra_isize + 3) & ~3;
> 		e2fsck_write_inode_full(ctx, pctx->ino, pctx->inode,
> 					EXT2_INODE_SIZE(sb), "pass1");
> -		return;
> 	}
> 
> 	/* check if there is no place for an EA header */

The problem is that if i_extra_isize is changed, then the EA magic and data
will no longer be aligned properly, so there isn't anything to check?


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)