linux-ext4 - Re: [PATCH 4/6] vfs: Add iomap_seek_hole and iomap_seek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 00:49:27 +0200
From:   Andreas Grünbacher <andreas.gruenbacher@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Andreas Gruenbacher <agruenba@...hat.com>, Jan Kara <jack@...e.cz>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 4/6] vfs: Add iomap_seek_hole and iomap_seek_data helpers

2017-06-28 0:43 GMT+02:00 Christoph Hellwig <hch@....de>:
> On Wed, Jun 28, 2017 at 12:14:57AM +0200, Andreas Grünbacher wrote:
>> This shouldn't be true anymore now that the actors don't recompute the
>> length; the above three lines should be obsolete.
>
> Indeed.
>
>> This comment makes more sense in iomap_seek_hole now.
>
> Or just drop it..
>
> What about the incremental patch below?

Ok.

> diff --git a/fs/iomap.c b/fs/iomap.c
> index c90cda33994b..432eed8f091f 100644
> --- a/fs/iomap.c
> +++ b/fs/iomap.c
> @@ -626,9 +626,6 @@ iomap_seek_hole(struct inode *inode, loff_t offset, const struct iomap_ops *ops)
>                 length -= ret;
>         }
>
> -       /* The last segment can extend beyond the end of the file. */
> -       if (length <= 0)
> -               return min(offset, size);
>         return offset;
>  }
>  EXPORT_SYMBOL_GPL(iomap_seek_hole);
> @@ -675,7 +672,6 @@ iomap_seek_data(struct inode *inode, loff_t offset, const struct iomap_ops *ops)
>                 length -= ret;
>         }
>
> -       /* There is an implicit hole at the end of the file. */
>         if (length <= 0)
>                 return -ENXIO;
>         return offset;

Thanks,
Andreas