linux-ext4 - Re: [PATCH] ext4: don't free an error pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeU0aN=qsJAHrmowwv499mkUCpTrA54yMdJP-NM8g7kZ3OFyQ@mail.gmail.com>
Date:   Fri, 30 Jun 2017 04:17:58 -0700
From:   Tahsin Erdogan <tahsin@...gle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext4: don't free an error pointer

Reviewed-by: Tahsin Erdogan <tahsin@...gle.com>

On Fri, Jun 30, 2017 at 12:56 AM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:
> "goto out;" calls brelse(bh); which will oops on this this path where
> "bh" is an error pointer.
>
> Fixes: 2851a40a5d71 ("ext4: xattr-in-inode support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Oops.  I wrote a bug report and a patch for this...  Probably we only
> need the patch.
>
>
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index ce12c3fb7e59..f7d6845e147b 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1305,10 +1305,8 @@ static int ext4_xattr_inode_write(handle_t *handle, struct inode *ea_inode,
>                 csize = (bufsize - wsize) > blocksize ? blocksize :
>                                                                 bufsize - wsize;
>                 bh = ext4_getblk(handle, ea_inode, block, 0);
> -               if (IS_ERR(bh)) {
> -                       ret = PTR_ERR(bh);
> -                       goto out;
> -               }
> +               if (IS_ERR(bh))
> +                       return PTR_ERR(bh);
>                 ret = ext4_journal_get_write_access(handle, bh);
>                 if (ret)
>                         goto out;