linux-ext4 - RE: [PATCH v2 1/2] ext4, project: expand inode extra size if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jul 2017 07:32:52 +0000
From:   Wang Shilong <wshilong@....com>
To:     "miaoxie@...wei.com" <miaoxie@...wei.com>,
        Andreas Dilger <adilger@...ger.ca>,
        Wang Shilong <wangshilong1991@...il.com>
CC:     linux-ext4 <linux-ext4@...r.kernel.org>,
        Theodore Ts'o <tytso@....edu>, "Li Xi" <lixi@....com>,
        "zhangyi (F)" <yi.zhang@...wei.com>, Shuichi Ihara <sihara@....com>
Subject: RE: [PATCH v2 1/2] ext4, project: expand inode extra size if
 possible


________________________________________
From: Miao Xie [miaoxie@...wei.com]
Sent: Thursday, July 06, 2017 11:51
To: Andreas Dilger; Wang Shilong
Cc: linux-ext4; Theodore Ts'o; Li Xi; zhangyi (F); Wang Shilong; Shuichi Ihara
Subject: Re: [PATCH v2 1/2] ext4, project: expand inode extra size if possible

Sorry, I reply late.

on 2017/7/6 at 0:31, Andreas Dilger wrote:
>>
>> +    if (need_expand) {
>> +            err = ext4_expand_extra_isize(inode,
>> +                                  EXT4_SB(sb)->s_want_extra_isize,
>> +                                  iloc, handle);
>> +            if (err)
>> +                    goto out_stop;
>> +    }
>> +

I found ext4_expand_extra_isize just tried to expand extra isize,
it would give up and return 0 if someone was holding attr lock.
so though it return 0, extra isize may not be expanded successfully.

---->yup, you are right, good point.

So ...

How about the following patches?

---->patches looks good for me, thanks for better fix and cleanup.

Thanks,
Shilong