linux-ext4 - Re: [PATCH] ext4: correct comment references to ext4_ext_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8BDF79B6-C881-40F6-9D2B-E8480F0035D2@dilger.ca>
Date:   Fri, 14 Jul 2017 14:18:00 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Eric Whitney <enwlinux@...il.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] ext4: correct comment references to ext4_ext_direct_IO()

On Jul 14, 2017, at 2:04 PM, Eric Whitney <enwlinux@...il.com> wrote:
> 
> Commit 914f82a32d0268847 "ext4: refactor direct IO code" deleted
> ext4_ext_direct_IO(), but references to that function remain in
> comments.  Update them to refer to ext4_direct_IO_write().
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 3c600f0..2e6c022 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -892,7 +892,7 @@ static int ext4_dio_get_block_unwritten_async(struct inode *inode,
> /*
>  * Get block function for non-AIO DIO writes when we create unwritten extent if
>  * blocks are not allocated yet. The extent will be converted to written
> - * after IO is complete from ext4_ext_direct_IO() function.
> + * after IO is complete by ext4_direct_IO_write().
>  */
> static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
> 		sector_t iblock, struct buffer_head *bh_result,	int create)
> @@ -907,7 +907,7 @@ static int ext4_dio_get_block_unwritten_sync(struct inode *inode,
> 
> 	/*
> 	 * Mark inode as having pending DIO writes to unwritten extents.
> -	 * ext4_ext_direct_IO() checks this flag and converts extents to
> +	 * ext4_direct_IO_write() checks this flag and converts extents to
> 	 * written.
> 	 */
> 	if (!ret && buffer_unwritten(bh_result))
> --
> 2.1.4
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)