linux-ext4 - Re: [PATCH v2] generic: test negative SEEK_HOLE/SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170714165757.GA4211@magnolia>
Date:   Fri, 14 Jul 2017 09:57:57 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Eryu Guan <eguan@...hat.com>
Cc:     linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        xfs <linux-xfs@...r.kernel.org>,
        linux-ext4 <linux-ext4@...r.kernel.org>,
        fstests <fstests@...r.kernel.org>
Subject: Re: [PATCH v2] generic: test negative SEEK_HOLE/SEEK_DATA offsets

On Fri, Jul 14, 2017 at 11:41:19AM +0800, Eryu Guan wrote:
> On Thu, Jul 13, 2017 at 12:06:41PM -0700, Darrick J. Wong wrote:
> > Check that we get -ENXIO if the user calls SEEK_HOLE/SEEK_DATA with
> > a negative file offset.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> > ---
> > v2: use helpers as suggested by Eryu.
> > ---
> [snip]
> > +
> > +seq=`basename "$0"`
> > +seqres="$RESULT_DIR/$seq"
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1    # failure is the default!
> > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > +
> > +_cleanup()
> > +{
> > +    cd /
> > +    rm -rf "$tmp".* $testdir/file1
> > +}
> 
> Just noticed there're two _cleanup()s, I'll remove this one and move the
> one below here.

Oops.  Thanks for catching that!

--D

> 
> Thanks,
> Eryu
> 
> > +
> > +# get standard environment, filters and checks
> > +. ./common/rc
> > +. ./common/filter
> > +
> > +_supported_fs generic
> > +_supported_os Linux
> > +
> > +_require_test
> > +_require_seek_data_hole
> > +
> > +BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile
> > +
> > +_require_test_program "seek_sanity_test"
> > +
> > +# Disable extent zeroing for ext4 as that change where holes are created
> > +if [ "$FSTYP" = "ext4" ]; then
> > +	DEV=`_short_dev $TEST_DEV`
> > +	echo 0 >/sys/fs/ext4/$DEV/extent_max_zeroout_kb
> > +fi
> > +
> > +_cleanup()
> > +{
> > +	rm -f $tmp.* $BASE_TEST_FILE.*
> > +}
> > +
> > +$here/src/seek_sanity_test -s 18 -e 18 $BASE_TEST_FILE > $seqres.full 2>&1 ||
> > +	_fail "seek sanity check failed!"
> > +
> > +_check_dmesg
> > +# success, all done
> > +echo "Silence is golden"
> > +status=0
> > +exit
> > diff --git a/tests/generic/702.out b/tests/generic/702.out
> > new file mode 100644
> > index 0000000..608d593
> > --- /dev/null
> > +++ b/tests/generic/702.out
> > @@ -0,0 +1,2 @@
> > +QA output created by 702
> > +Silence is golden
> > diff --git a/tests/generic/group b/tests/generic/group
> > index 3c5a19c..6afd402 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -449,4 +449,5 @@
> >  444 auto quick acl
> >  445 auto quick rw
> >  446 auto quick rw dangerous
> > +702 auto quick rw
> >  931 auto quick clone