linux-ext4 - Re: [PATCH 2/2] e2p: Fix segfault in e2p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0C49EE02-6D84-4CD8-A0A7-C0224AF9916F@dilger.ca>
Date:   Tue, 18 Jul 2017 14:04:52 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Adam Buchbinder <abuchbinder@...gle.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/2] e2p: Fix segfault in e2p_os2string.

On Jul 18, 2017, at 1:29 PM, Adam Buchbinder <abuchbinder@...gle.com> wrote:
> 
> Passing in a negative integer would lead to a segfault, and
> a crafted filesystem image could trigger that.
> 
> Signed-off-by: Adam Buchbinder <abuchbinder@...gle.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Note that it would be better to land this patch as 1/2, and the test which
causes the segfault as 2/2, otherwise it could break git bisect.

Cheers, Andreas
> ---
> lib/e2p/ostype.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/e2p/ostype.c b/lib/e2p/ostype.c
> index 7f088446..c5fd8ab3 100644
> --- a/lib/e2p/ostype.c
> +++ b/lib/e2p/ostype.c
> @@ -30,7 +30,7 @@ char *e2p_os2string(int os_type)
>         const char	*os;
> 	char 		*ret;
> 
> -	if (os_type <= EXT2_OS_LITES)
> +	if (os_type >= 0 && os_type <= EXT2_OS_LITES)
> 		os = os_tab[os_type];
> 	else
> 		os = "(unknown os)";

Cheers, Andreas

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)