linux-ext4 - Re: [PATCH v2 2/2] tests: dumpe2fs against an image with bad os

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BE3EE935-5045-4D07-8BE4-37C7F04246DC@dilger.ca>
Date:   Tue, 18 Jul 2017 16:32:45 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Adam Buchbinder <abuchbinder@...gle.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 2/2] tests: dumpe2fs against an image with bad os_type.

On Jul 18, 2017, at 3:48 PM, Adam Buchbinder <abuchbinder@...gle.com> wrote:
> 
> The os_type here is large enough to be negative when interpreted as a
> signed integer.
> 
> This test case was generated by american fuzzy lop, starting from a
> base filesystem image from files.fuzzing-project.org.
> 
> Signed-off-by: Adam Buchbinder <abuchbinder@...gle.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> tests/d_bad_ostype/expect |  1 +
> tests/d_bad_ostype/name   |  1 +
> tests/d_bad_ostype/script | 21 +++++++++++++++++++++
> 3 files changed, 23 insertions(+)
> create mode 100644 tests/d_bad_ostype/expect
> create mode 100644 tests/d_bad_ostype/name
> create mode 100644 tests/d_bad_ostype/script
> 
> diff --git a/tests/d_bad_ostype/expect b/tests/d_bad_ostype/expect
> new file mode 100644
> index 00000000..b00318c4
> --- /dev/null
> +++ b/tests/d_bad_ostype/expect
> @@ -0,0 +1 @@
> +Filesystem OS type:       (unknown os)
> diff --git a/tests/d_bad_ostype/name b/tests/d_bad_ostype/name
> new file mode 100644
> index 00000000..3da887a8
> --- /dev/null
> +++ b/tests/d_bad_ostype/name
> @@ -0,0 +1 @@
> +handle bad (negative) os_type
> diff --git a/tests/d_bad_ostype/script b/tests/d_bad_ostype/script
> new file mode 100644
> index 00000000..992a3030
> --- /dev/null
> +++ b/tests/d_bad_ostype/script
> @@ -0,0 +1,21 @@
> +dd if=/dev/zero of=$TMPFILE bs=1k count=64 > /dev/null 2>&1
> +$MKE2FS -q -b 1024 $TMPFILE
> +$DEBUGFS -w -R 'set_super_value creator_os 0xf0000000' $TMPFILE
> +
> +OUT=$test_name.log
> +EXP=$test_dir/expect
> +$DUMPE2FS $TMPFILE 2>&1 | sed -f $cmd_dir/filter.sed | grep 'Filesystem OS type:' > $OUT
> +
> +rm -f $TMPFILE
> +cmp -s $OUT $EXP
> +status=$?
> +
> +if [ "$status" = 0 ] ; then
> +        echo "$test_name: $test_description: ok"
> +        touch $test_name.ok
> +else
> +        echo "$test_name: $test_description: failed"
> +        diff $DIFF_OPTS $EXP $OUT > $test_name.failed
> +        rm -f $test_name.tmp
> +fi
> +unset OUT EXP
> --
> 2.14.0.rc0.284.gd933b75aa4-goog
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)