linux-ext4 - Re: [PATCH 3/4] libext2fs: eliminate empty element holes in ext2_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170724025351.seejfxujn2wzplzo@thunk.org>
Date:   Sun, 23 Jul 2017 22:53:51 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/4] libext2fs: eliminate empty element holes in
 ext2_xattr_handle->attrs

On Fri, Jul 07, 2017 at 05:12:45AM -0700, Tahsin Erdogan wrote:
> When an extended attribute is removed, its array element is emptied.
> This creates holes in the array so various places that want to walk
> filled elements have to do an empty element check.
> 
> Have remove operation shift remaining filled elements to the left.
> This allows a simple iteration up to ext2_xattr_handle->count to walk
> all filled entries, and so empty element checks become unnecessary.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, applied.

						- Ted