linux-ext4 - Re: [PATCH] ext4: remove unused metadata accounting variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170731023451.pm75sx7isl3oscf4@thunk.org>
Date:   Sun, 30 Jul 2017 22:34:51 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Eric Whitney <enwlinux@...il.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove unused metadata accounting variables

On Thu, Jul 13, 2017 at 05:58:32PM +0200, Jan Kara wrote:
> On Thu 13-07-17 10:57:08, Eric Whitney wrote:
> > Two variables in ext4_inode_info, i_reserved_meta_blocks and
> > i_allocated_meta_blocks, are unused.  Removing them saves a little
> > memory per in-memory inode and cleans up clutter in several tracepoints.
> > Adjust tracepoint output from ext4_alloc_da_blocks() for consistency
> > and fix a typo and whitespace near these changes.
> > 
> > Signed-off-by: Eric Whitney <enwlinux@...il.com>
> 
> Looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted