linux-ext4 - Re: [PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170731045622.ez4tjhuvmjrpvizc@thunk.org>
Date:   Mon, 31 Jul 2017 00:56:22 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] ext4: convert swap_inode_data() over to use swap() on
 most of the fields

On Wed, Jul 05, 2017 at 12:32:07PM -0400, Jeff Layton wrote:
> From: Jeff Layton <jlayton@...hat.com>
> 
> For some odd reason, it forces a byte-by-byte copy of each field. A
> plain old swap() on most of these fields would be more efficient. We
> do need to retain the memswap of i_data however as that field is an array.
> 
> Signed-off-by: Jeff Layton <jlayton@...hat.com>
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted