linux-ext4 - Re: [PATCH] ext4: silence array overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170805230118.5olcshags2qerb6y@thunk.org>
Date:   Sat, 5 Aug 2017 19:01:18 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext4: silence array overflow warning

On Tue, Jul 18, 2017 at 12:27:02PM +0300, Dan Carpenter wrote:
> I get a static checker warning:
> 
>     fs/ext4/ext4.h:3091 ext4_set_de_type()
>     error: buffer overflow 'ext4_type_by_mode' 15 <= 15
> 
> It seems unlikely that we would hit this read overflow in real life, but
> it's also simple enough to make the array 16 bytes instead of 15.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks, applied.

					- Ted