linux-ext4 - Re: [PATCH] ext4: add missing xattr hash update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170814123116.cr3r2jmqon5axgzx@thunk.org>
Date:   Mon, 14 Aug 2017 08:31:17 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        Miklos Szeredi <miklos@...redi.hu>,
        zhangyi <yizhang089@...il.com>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: add missing xattr hash update

On Sun, Aug 06, 2017 at 01:03:19PM -0700, Tahsin Erdogan wrote:
> When updating an extended attribute, if the padded value sizes are the
> same, a shortcut is taken to avoid the bulk of the work. This was fine
> until the xattr hash update was moved inside ext4_xattr_set_entry().
> With that change, the hash update got missed in the shortcut case.
> 
> Thanks to ZhangYi (yizhang089@...il.com) for root causing the problem.
> 
> Fixes: daf8328172df ("ext4: eliminate xattr entry e_hash recalculation for removes")
> 
> Reported-by: Miklos Szeredi <miklos@...redi.hu>
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, applied.

					- Ted