linux-ext4 - Re: [PATCH] ext4: in ext4_seek_{hole,data}, return -ENXIO for negative offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170824172720.3inhcbeoozw2rdhh@thunk.org>
Date:   Thu, 24 Aug 2017 13:27:20 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     linux-ext4@...r.kernel.org, Mateusz S <muttdini@...il.com>
Subject: Re: [PATCH] ext4: in ext4_seek_{hole,data}, return -ENXIO for
 negative offsets

On Wed, Jul 12, 2017 at 10:32:32AM -0700, Darrick J. Wong wrote:
> NOTE: The pending iomap SEEK_HOLE/DATA conversion patch will make all this
> obsolete; this is a fix more appropriate for pre-4.13 ext4.
> ---
> In the ext4 implementations of SEEK_HOLE and SEEK_DATA, make sure we
> return -ENXIO for negative offsets instead of banging around inside
> the extent code and returning -EFSCORRUPTED.
> 
> Reported-by: Mateusz S <muttdini@...il.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Sorry, I missed this patch earlier.  It's not going to make the 4.13
final, but I'll apply it with a "cc: stable@...r.kernel.org # 4.6" tag
so it can land in 4.13.x as well as older LTS kernels.

     	       	       	  	    - Ted