linux-ext4 - Re: ext4/hash.c: remove useless test and assignment in strtohash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170824191307.wv5mrksfhty7gp2e@thunk.org>
Date:   Thu, 24 Aug 2017 15:13:07 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Damien Guibouret <damien.guibouret@...tition-saving.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: ext4/hash.c: remove useless test and assignment in strtohash

On Thu, Jul 27, 2017 at 10:53:27PM +0200, Damien Guibouret wrote:
> On transformation of str to hash, computed value is initialised before
> first byte modulo 4. But it is already initialised before entering loop
> and after processing last byte modulo 4. So the corresponding test and
> initialisation could be removed.
> 
> Signed-off-by: Damien Guibouret <damien.guibouret@...tition-saving.com>

Thanks, applied.

					- Ted