linux-ext4 - Re: [PATCH 1/2] ext4: fix incorrect quotaoff if the quota feature is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170824192042.jxcwte2qouetd5tr@thunk.org>
Date:   Thu, 24 Aug 2017 15:20:42 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     "zhangyi (F)" <yi.zhang@...wei.com>, linux-ext4@...r.kernel.org,
        adilger.kernel@...ger.ca, miaoxie@...wei.com
Subject: Re: [PATCH 1/2] ext4: fix incorrect quotaoff if the quota feature is
 enabled

On Wed, Aug 23, 2017 at 12:00:00PM +0200, Jan Kara wrote:
> On Wed 23-08-17 17:13:57, zhangyi (F) wrote:
> > Current ext4 quota should always "usage enabled" if the
> > quota feautre is enabled. But in ext4_orphan_cleanup(), it
> > turn quotas off directly (used for the older journaled
> > quota), so we cannot turn it on again via "quotaon" unless
> > umount and remount ext4.
> > 
> > Simple reproduce:
> > 
> >   mkfs.ext4 -O project,quota /dev/vdb1
> >   mount -o prjquota /dev/vdb1 /mnt
> >   chattr -p 123 /mnt
> >   chattr +P /mnt
> >   touch /mnt/aa /mnt/bb
> >   exec 100<>/mnt/aa
> >   rm -f /mnt/aa
> >   sync
> >   echo c > /proc/sysrq-trigger
> > 
> >   #reboot and mount
> >   mount -o prjquota /dev/vdb1 /mnt
> >   #query status
> >   quotaon -Ppv /dev/vdb1
> >   #output
> >   quotaon: Cannot find mountpoint for device /dev/vdb1
> >   quotaon: No correct mountpoint specified.
> > 
> > This patch add check for journaled quotas to avoid incorrect
> > quotaoff when ext4 has quota feautre.
> > 
> > Signed-off-by: zhangyi (F) <yi.zhang@...wei.com>
> 
> Looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted