linux-ext4 - Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171003070000.GA5162@lvzheng-thinkpad>
Date:   Tue, 3 Oct 2017 15:00:00 +0800
From:   Zheng Lv <lv.zheng.2015@...il.com>
To:     nborisov@...e.com
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes

> No functional changes, just makes the code a bit more readable. Also fix 1
> trailing whitespace

I don't think so.

AFAIK, SZ_16 is just 16, not (16 * 1024). XXX * 1024 should be replaced with
SZ_XXXk rather than SZ_XXX.

Cheers
Zheng Lv