linux-ext4 - Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171003161714.w6axjxymb45mwno5@thunk.org>
Date:   Tue, 3 Oct 2017 12:17:14 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Nikolay Borisov <nborisov@...e.com>
Cc:     Zheng Lv <lv.zheng.2015@...il.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes

On Tue, Oct 03, 2017 at 12:31:45PM +0300, Nikolay Borisov wrote:
> 
> 
> On  3.10.2017 10:00, Zheng Lv wrote:
> >> No functional changes, just makes the code a bit more readable. Also fix 1
> >> trailing whitespace
> > 
> > I don't think so.
> > 
> > AFAIK, SZ_16 is just 16, not (16 * 1024). XXX * 1024 should be replaced with
> > SZ_XXXk rather than SZ_XXX.
> 
> True, I meant kilobytes and not bytes, so my bad. THe patch is buggy
> will redo it and resend. Thanks for spotting it.

The symbolic constants don't also seem to add much in terms of
readability, at least to my view....

				- Ted