lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <96fd009e4552b48cd9d4e4f776dc7d20@be409.mail.saunalahti.fi> Date: Thu, 05 Oct 2017 08:25:50 +0300 From: eru@...ti.fi To: linux-ext4@...r.kernel.org Subject: [PATCH] tune2fs: prevent crash if error in journal recovery Prevent coredump if tunefs calls ext2fs_run_ext3_journal(), and this then fails for some reason while calling ext2fs_open2(). Such failure makes the fs pointer NULL. Signed-off-by: Erkki Ruohtula <eru@...ti.fi> --- diff --git a/misc/tune2fs.c b/misc/tune2fs.c index ecba2ea..6538032 100644 --- a/misc/tune2fs.c +++ b/misc/tune2fs.c @@ -3367,6 +3367,9 @@ closefs: #endif } - convert_64bit(fs, feature_64bit); - return (ext2fs_close_free(&fs) ? 1 : 0); + if (fs) { + convert_64bit(fs, feature_64bit); + return (ext2fs_close_free(&fs) ? 1 : 0); + } + return 1; }
Powered by blists - more mailing lists