linux-ext4 - Re: [PATCH] ext4/026: skip test if kernel does not support the ea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171008215110.qxhel7nkcsifybu2@thunk.org>
Date:   Sun, 8 Oct 2017 17:51:10 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Dave Chinner <david@...morbit.com>
Cc:     fstests@...r.kernel.org,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4/026: skip test if kernel does not support the
 ea_inode feature

On Mon, Oct 09, 2017 at 08:41:17AM +1100, Dave Chinner wrote:
> On Sun, Oct 08, 2017 at 03:23:24PM -0400, Theodore Ts'o wrote:
> > Signed-off-by: Theodore Ts'o <tytso@....edu>
> > ---
> >  tests/ext4/026 | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/ext4/026 b/tests/ext4/026
> > index 94a737ce..ba77f36e 100755
> > --- a/tests/ext4/026
> > +++ b/tests/ext4/026
> > @@ -53,7 +53,8 @@ _require_attrs
> >  _require_ext4_mkfs_feature ea_inode
> >  
> >  _scratch_mkfs_ext4 -O ea_inode >/dev/null 2>&1
> > -_scratch_mount
> > +_scratch_mount >/dev/null 2>&1 \
> > +	|| _notrun "kernel doesn't support ea_inode feature on $FSTYP"
> 
> Needs to be in a _requires check?

There's only one test currently testing ea_inode at the moment, but
sure, I can make it into a _requires check.

      	    	    	   - Ted