lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171019131735.GC20645@lst.de> Date: Thu, 19 Oct 2017 15:17:35 +0200 From: Christoph Hellwig <hch@....de> To: Jan Kara <jack@...e.cz> Cc: linux-fsdevel@...r.kernel.org, linux-nvdimm@...ts.01.org, Ross Zwisler <ross.zwisler@...ux.intel.com>, Dan Williams <dan.j.williams@...el.com>, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, Christoph Hellwig <hch@...radead.org>, linux-api@...r.kernel.org, Christoph Hellwig <hch@....de> Subject: Re: [PATCH 17/17] xfs: support for synchronous DAX faults > +#define XFS_MAP_SUPPORTED (LEGACY_MAP_MASK | MAP_SYNC) I'd kill this define. Also is there any good reason that we have to add LEGACY_MAP_MASK instead of assuming it's supported in the core? > #endif > .mmap = xfs_file_mmap, > + .mmap_supported_flags = XFS_MAP_SUPPORTED, > .open = xfs_file_open, > .release = xfs_file_release, > .fsync = xfs_file_fsync, I usually either reformat all members to be aligned again, or if that's too much churn (in this case it probably is) just use a single space before the = to minimize the alignment differences. Otherwise your changes look good to me.
Powered by blists - more mailing lists