lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171025075414.mnizap2yjcmgkpn7@gaztest-VM> Date: Wed, 25 Oct 2017 13:24:14 +0530 From: Gazala Muhamed <teamathena.nitc@...il.com> To: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, teamathena.nitc@...il.com Subject: [PATCH v2] Make a log in dmesg when file creation fails due to no free inodes The error code for both "out of disk space" and "out of inodes" is the same This is misleading to the user. Logging the exact reason helps to find and debug the issue from the user's side. Fix bug 197335 - https://bugzilla.kernel.org/show_bug.cgi?id=197335 Signed-off-by: Gazala Muhamed <teamathena.nitc@...il.com> --- Changes in v2: - Use ext4_warning instead of a bare printk - Signed-off with real name --- fs/ext4/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index c1cf020d..4b18badd 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2463,6 +2463,8 @@ static int ext4_create(struct inode *dir, struct dentry *dentry, umode_t mode, ext4_journal_stop(handle); if (err == -ENOSPC && ext4_should_retry_alloc(dir->i_sb, &retries)) goto retry; + else if (err == -ENOSPC) + ext4_warning(dir->i_sb, "No space on disk, out of inodes"); return err; } -- 2.11.0
Powered by blists - more mailing lists