linux-ext4 - Re: [PATCH] libext2fs: add missing swab for superblock, add checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171214034121.bmusgiypnn6iu77d@thunk.org>
Date:   Wed, 13 Dec 2017 22:41:21 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] libext2fs: add missing swab for superblock, add checks

On Wed, Dec 13, 2017 at 04:47:14PM -0700, Andreas Dilger wrote:
> Several recently-added fields in struct ext2_super_block were
> not being swabbed in ext2fs_swap_super(), in particular:
> 
>    s_raid_stride, s_raid_stripe_width, s_{first,last}_error_*
>    s_lpf_ino, s_prj_quota_inum
> 
> Add swabbing for these missing fields.  Reorder the swabbing
> on other fields so that they are in struct order, and add
> comments for fields that do not need swabbing, so it is easier
> to see that all fields are being handled.
> 
> Since this seems to be a fairly common occurrence, add compile
> time checks to ext2fs_swap_super(), ext2fs_swap_inode_large(),
> and ext2fs_swap_group_desc2() via a new EXT2FS_BUILD_BUG_ON()
> macro to cause a compile warning if fields are used from these
> structs without a corresponding change to the swab functions.
> 
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Reported-by: Artem Blagodarenko <artem.blagodarenko@...il.com>
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Applied, thanks.

						- Ted