linux-ext4 - FS: EXT4: should we sync error info in __ext4_grp_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAABZP2w39PEBue-L1kGk-jh_WQohTtaVJHy-wS_E7QC28FKJSA@mail.gmail.com>
Date:   Thu, 14 Dec 2017 15:13:15 +0800
From:   Zhouyi Zhou <zhouzhouyi@...il.com>
To:     linux-ext4@...r.kernel.org, tytso@....edu,
        linux-kernel@...r.kernel.org, inux-fsdevel@...r.kernel.org
Subject: FS: EXT4: should we sync error info in __ext4_grp_locked_error?

Hi,
    In function __ext4_grp_locked_error,   __save_error_info(sb, function, line)
is called to save error info in super block block, but does not sync
that information
to disk to info the subsequence fsck after reboot. The reason, I guess
maybe it is
in locked state.
    My question is why not make a call ext4_commit_super(sb, 1) after
ext4_unlock_group(sb, grp) and  ext4_handle_error(sb), so that subsequence fsck
after reboot is sure to be well informed.
   Forgive my naiveness.
Thanks a lot