linux-ext4 - [QUESTION] Locking for the transaction buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ced83bc-4afa-998e-8015-bab5e2441c49@tu-dortmund.de>
Date:   Mon, 18 Dec 2017 18:08:34 +0100
From:   Alexander Lochmann <alexander.lochmann@...dortmund.de>
To:     linux-ext4@...r.kernel.org
Cc:     Horst Schirmeier <horst.schirmeier@...dortmund.de>
Subject: [QUESTION] Locking for the transaction buffers

Hi developers,

I'm studying the locking in the JBD2 subsystem (v4.15-rc4). Doing so, I
came across the jbd2_journal_commit_transaction function
where severals lists, e.g., t_forget or t_buffers, are flushed in a
while loop.
According to the documentation in inlcude/linux/jbd2.h, the j_list_lock
lock is the appropriate lock.
However, it is only used in one out of three cases:
In fs/jbd2/commit.c:903, the while loop is protected using the
j_list_lock lock. Whereas it is not used at line 464 and 561.
In contrast to that, the insert and remove operations to any of these
lists are protected by that lock.

Can you please tell me why that lock is not used at line 464 and 561?

Thanks in advance!

Regards,
Alex

-- 
Technische Universität Dortmund
Alexander Lochmann                PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16                 phone:  +49.231.7556141
D-44227 Dortmund                  fax:    +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al

Download attachment "signature.asc" of type "application/pgp-signature" (851 bytes)