[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <F976B3B9-90C4-446E-B8D4-49571CA535A4@dilger.ca>
Date: Fri, 29 Dec 2017 16:02:04 -0700
From: Andreas Dilger <adilger@...ger.ca>
To: Theodore Ts'o <tytso@....edu>
Cc: linux-ext4 <linux-ext4@...r.kernel.org>,
Shuichi Ihara <sihara@....com>, Li Xi <lixi@....com>,
Wang Shilong <wshilong@....com>
Subject: Re: [PATCH] misc: add e2mmpstatus utility
On Dec 22, 2017, at 10:17 AM, Theodore Ts'o <tytso@....edu> wrote:
>
> On Fri, Dec 22, 2017 at 02:22:44AM -0700, Andreas Dilger wrote:
>> From: Shuichi Ihara <sihara@....com>
>>
>> e2mmpstatus is an MMP helper utility to read status from an MMP block.
>> It outputs the latest MMP updated nodename and time for the device.
>
> Why not include this into dumpe2fs? Maybe dumpe2fs -m to just print
> the MMP information and include the MMP nodetime and time for either
> the full dumpe2fs or dumpe2fs -h output?
That would definitely be an option. The mmpstatus utility was written by
DDN, and I'm passing it on after some code cleanup.
I think it would be reasonable to include the other MMP fields into the
dumpe2fs output, and then run the full MMP activity check if called with
"-m" or named as "mmpstatus". I don't want dumpe2fs to be blocked on
the MMP update checking all the time, since that can be slow.
I'll see if I can get a patch out in the next couple of days.
Cheers, Andreas
Powered by blists - more mailing lists