lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20180106180654.7373-1-ebiggers3@gmail.com> Date: Sat, 6 Jan 2018 10:06:54 -0800 From: Eric Biggers <ebiggers3@...il.com> To: linux-fsdevel@...r.kernel.org Cc: linux-ext4@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Theodore Ts'o <tytso@....edu>, Eric Biggers <ebiggers@...gle.com>, Jan Kara <jack@...e.cz>, Jiang Biao <jiang.biao2@....com.cn> Subject: [PATCH] Revert "fs/mbcache.c: make count_objects() more robust" From: Eric Biggers <ebiggers@...gle.com> This reverts commit d5dabd633922ac5ee5bcc67748f7defb8b211469. This patch did absolutely nothing, because ->c_entry_count is unsigned. In addition if there is a bug in how mbcache maintains its entry count, it needs to be fixed, not just hacked around. (There is no obvious bug, though.) Cc: Jan Kara <jack@...e.cz> Cc: Jiang Biao <jiang.biao2@....com.cn> Signed-off-by: Eric Biggers <ebiggers@...gle.com> --- fs/mbcache.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/mbcache.c b/fs/mbcache.c index b8b8b9ced9f8..d818fd236787 100644 --- a/fs/mbcache.c +++ b/fs/mbcache.c @@ -269,9 +269,6 @@ static unsigned long mb_cache_count(struct shrinker *shrink, struct mb_cache *cache = container_of(shrink, struct mb_cache, c_shrink); - /* Unlikely, but not impossible */ - if (unlikely(cache->c_entry_count < 0)) - return 0; return cache->c_entry_count; } -- 2.15.1
Powered by blists - more mailing lists