linux-ext4 - Re: [PATCH] ext4.h: Fixed alignment and minor code cleanup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180108045729.GG17380@thunk.org>
Date:   Sun, 7 Jan 2018 23:57:29 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Petros Koutoupis <petros@...roskoutoupis.com>
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4.h: Fixed alignment and minor code cleanup.

On Wed, Dec 20, 2017 at 02:09:18PM -0600, Petros Koutoupis wrote:
> Minor code cleanup: Fixed alignment and a reduction of lines in header file.
> 
> Signed-off-by: Petros Koutoupis <petros@...roskoutoupis.com>

The patch is whitespace damaged, unfortunately.

Also, the cleanup actually isn't the best cleanup.  We should really
be changing ext4_chksum() to take a struct super instead of a struct
ext4_sb_info, so we can call ext4_std_error() so we can properly log
an error without immediately crashing the kernel.  The chksum
shouldn't really ever fail, but if it does, calling ext4_error() is
better than bringing down the whole system with a BUG_ON.

Cheers,
						- Ted