linux-ext4 - [PATCH] common/rc: ext4 doesn't support O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180110211905.4ulqeqnwbs2bh66o@localhost.localdomain>
Date:   Wed, 10 Jan 2018 16:19:05 -0500
From:   Eric Whitney <enwlinux@...il.com>
To:     fstests@...r.kernel.org
Cc:     linux-ext4@...r.kernel.org
Subject: [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling

Modify _require_odirect() to skip O_DIRECT tests if the ext4 mount
option data=journal has been applied.  Because ext4 disables its
O_DIRECT support when in data journaling mode, no significant value is
obtained by running these tests and they consume a significant amount
of run time.  Additionally, this change eliminates the need to triage
false negative O_DIRECT test results caused by test problems, as has
occurred from time to time.

Signed-off-by: Eric Whitney <enwlinux@...il.com>
---
 common/rc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/rc b/common/rc
index 9216efdb..86cc9665 100644
--- a/common/rc
+++ b/common/rc
@@ -2150,6 +2150,8 @@ _require_odirect()
 	if [ $FSTYP = "ext4" ] ; then
 		if echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption"; then
 			_notrun "ext4 encryption doesn't support O_DIRECT"
+		elif echo "$MOUNT_OPTIONS" | grep -q "data=journal"; then
+			_notrun "ext4 data journaling doesn't support O_DIRECT"
 		fi
 	fi
 	testfile=$TEST_DIR/$$.direct
-- 
2.11.0