linux-ext4 - [PATCH] ext4: no need flush workqueue before destroying it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5A555C01.8000400@huawei.com>
Date:   Wed, 10 Jan 2018 08:19:13 +0800
From:   piaojun <piaojun@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     <adilger.kernel@...ger.ca>, <arnd@...db.de>,
        Ted Tso <tytso@....edu>, <linux-ext4@...r.kernel.org>
Subject: [PATCH] ext4: no need flush workqueue before destroying it

destroy_workqueue() will do flushing work for us.

Signed-off-by: Jun Piao <piaojun@...wei.com>
Reviewed-by: Jan Kara <jack@...e.cz>
---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0556cd0..2f46b0b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);

-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);

 	if (sbi->s_journal) {
--