lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 11 Jan 2018 14:18:10 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Colin King <colin.king@...onical.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: fix incorrect indentation of if statement

On Thu, Jan 04, 2018 at 04:40:18PM +0100, Jan Kara wrote:
> On Wed 29-11-17 14:20:59, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The indentation is incorrect and spaces need replacing with a tab
> > on the if statement.
> > 
> > Cleans up smatch warning:
> > fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> This seems to fall through cracks. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.  There was actually another whitespace issue on the
following line, which I've fixed up and merged into this patch.

	  	      	   	    	- Ted

Powered by blists - more mailing lists