linux-ext4 - Re: [RFC PATCH] ext4: don't split xattr inode refcounts across i_ctime and i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180111183914.GE19241@thunk.org>
Date:   Thu, 11 Jan 2018 13:39:14 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        dhowells@...hat.com
Subject: Re: [RFC PATCH] ext4: don't split xattr inode refcounts across
 i_ctime and i_version fields

On Tue, Jan 09, 2018 at 02:05:31PM -0500, Jeff Layton wrote:
>
> Ahh, many thanks...
> 
> My main question was: why split the refcount across fields like this? If
> it's necessary now for backward compatibility then so be it, but it's
> weird and not 100% clear why it's being done that way.

The main reason is that the only inode that will need it is the hidden
extended attribute inode (and then only for Samba servers that are
supporting enterprise domain CIFS servers where there are more than
64k files using the same windows ACL).  So we didn't want to use extra
bytes in the inode, since it's only going to be used in a very tiny
fraction of servers.

For the right workload, though, this should allow ext4 to have
significantly better performance, since if you are serving a large
directory where all of the files have their own ACL or Windows
security ID xattrs, without shared extended attributes, when you open
a Files explorer on that directory, for each file the file system will
be forced to do lots of random 4k reads to fetch the xattrs.

   	     	     	       	  	- Ted