linux-ext4 - Re: [RFC PATCH 2/8] fs/buffer.c: make some functions non-static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5174754.qQ3mymzVSl@localhost.localdomain>
Date:   Sat, 13 Jan 2018 10:55:11 +0530
From:   Chandan Rajendra <chandan@...ux.vnet.ibm.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        tytso@....edu
Subject: Re: [RFC PATCH 2/8] fs/buffer.c: make some functions non-static

On Friday, January 12, 2018 8:08:23 PM IST Matthew Wilcox wrote:
> On Fri, Jan 12, 2018 at 07:41:23PM +0530, Chandan Rajendra wrote:
> > @@ -1642,12 +1642,12 @@ EXPORT_SYMBOL(clean_bdev_aliases);
> >   * constraints in mind (relevant mostly if some
> >   * architecture has a slow bit-scan instruction)
> >   */
> > -static inline int block_size_bits(unsigned int blocksize)
> > +int block_size_bits(unsigned int blocksize)
> >  {
> >  	return ilog2(blocksize);
> >  }
> 
> Could you move this to buffer.h instead please?
> 
> 

It just occured to me that I could use inode->i_blkbits instead of
block_size_bits() inside the new function ext4_block_read_full_page().
Hence I will drop the above change from the next version of the patchset.

Thanks for the review.

-- 
chandan