linux-ext4 - Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124050424.GD5594@magnolia>
Date:   Tue, 23 Jan 2018 21:04:24 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Tyson Nottingham <tgnottingham@...il.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.

On Tue, Jan 23, 2018 at 07:33:17PM -0800, Tyson Nottingham wrote:
> This message was inadvertently copied from the version of do_dump_mmp
> that is used when CONFIG_MMP is disabled.
> 
> Signed-off-by: Tyson Nottingham <tgnottingham@...il.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

> ---
>  debugfs/debugfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 91ededf..e46532f 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -2366,8 +2366,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
>  	fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
>  	fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
>  	fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
> -	fprintf(stdout, "MMP is unsupported, please recompile with "
> -	                "--enable-mmp\n");
>  }
>  #else
>  void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
> -- 
> 2.7.4
>