linux-ext4 - Re: [PATCH] ext4: make huge file flag user visible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124050930.GF5594@magnolia>
Date:   Tue, 23 Jan 2018 21:09:30 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Tyson Nottingham <tgnottingham@...il.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca
Subject: Re: [PATCH] ext4: make huge file flag user visible.

On Tue, Jan 23, 2018 at 09:03:33PM -0800, Darrick J. Wong wrote:
> On Tue, Jan 23, 2018 at 08:15:48PM -0800, Tyson Nottingham wrote:
> > Make huge file flag visible to clients of FS_IOC_GETFLAGS ioctl, e.g.
> > the userspace tool lsattr, which expects the flag to be visible.
> 
> Pardon my asking, but why is this necessary?  Are there
> userspace-visible effects of this flag?

Ahh, the chattr man page says that 'h' means HUGE_FILE_FL, but I guess
ext4 won't report it to userspace...?

<shrug> XFS won't either, maybe we just kill the 'h' option? :)

--D

> 
> --D
> 
> > 
> > Signed-off-by: Tyson Nottingham <tgnottingham@...il.com>
> > ---
> >  fs/ext4/ext4.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index 3241475..dbd6318 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -400,7 +400,7 @@ struct flex_groups {
> >  #define EXT4_PROJINHERIT_FL		0x20000000 /* Create with parents projid */
> >  #define EXT4_RESERVED_FL		0x80000000 /* reserved for ext4 lib */
> >  
> > -#define EXT4_FL_USER_VISIBLE		0x304BDFFF /* User visible flags */
> > +#define EXT4_FL_USER_VISIBLE		0x304FDFFF /* User visible flags */
> >  #define EXT4_FL_USER_MODIFIABLE		0x204BC0FF /* User modifiable flags */
> >  
> >  /* Flags we can manipulate with through EXT4_IOC_FSSETXATTR */
> > -- 
> > 2.7.4
> >