linux-ext4 - Re: [PATCH v5 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7657c80b-412b-e280-f126-a7d735a0a730@intel.com>
Date:   Thu, 15 Feb 2018 15:44:48 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     darrick.wong@...cle.com, linux-nvdimm@...ts.01.org,
        david@...morbit.com, linux-xfs@...r.kernel.org,
        ross.zwisler@...ux.intel.com, linux-ext4@...r.kernel.org,
        dan.j.williams@...el.com
Subject: Re: [PATCH v5 3/3] xfs: reject removal of realtime flag when datadev
 doesn't support DAX



On 02/15/2018 02:47 PM, Christoph Hellwig wrote:
>> +	if ((XFS_IS_REALTIME_INODE(ip)) &&
> 
> No need for the inner braces.

Ok I'll fix

> 
> Except for that the whole series looks fine to me.
> 

Can I add your reviewed-by? Thanks for reviewing.