lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Mar 2018 16:53:58 -0500 From: Theodore Ts'o <tytso@....edu> To: Eric Biggers <ebiggers3@...il.com> Cc: linux-ext4@...r.kernel.org, Jin Qian <jinqian@...gle.com>, Eric Biggers <ebiggers@...gle.com> Subject: Re: [e2fsprogs PATCH] blkid: fix building e2fsprogs with internal libblkid On Thu, Mar 01, 2018 at 09:21:35PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@...gle.com> > > Building e2fsprogs with the internal libblkid fails for me with the > following compiler error: > > In file included from blkidP.h:27:0, > from dev.c:17: > dev.c: In function ‘blkid_free_dev’: > ../../lib/blkid/list.h:149:42: error: ‘intptr_t’ undeclared (first use in this function); did you mean ‘__intptr_t’? > ((type *)((char *)(ptr)-(unsigned long)(intptr_t)(&((type *)0)->member))) > > The problem is that lib/blkid/list.h is now using 'intptr_t', but > stdint.h is not guaranteed to have been included yet. Include it. > > Fixes: 0a3d8041892c ("AOSP: build mke2fs for windows using android mingw library") > Signed-off-by: Eric Biggers <ebiggers@...gle.com> Thanks for pointing this out! I've fixed slightly modified your patch to try using inttypes.h preferentially and to use HAVE_xxx_H #ifdefs, e.g: #ifdef HAVE_INTTYPES_H #include <inttypes.h> #else #ifdef HAVE_STDINT_H #include <stdint.h> #endif #endif - Ted
Powered by blists - more mailing lists