linux-ext4 - Re: [PATCH] filefrag: avoid temporary buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 13:47:12 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     Andreas Dilger <andreas.dilger@...el.com>,
        linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH] filefrag: avoid temporary buffer overflow

On Fri, Mar 02, 2018 at 09:48:28AM -0800, Darrick J. Wong wrote:
> On Thu, Mar 01, 2018 at 01:09:46PM -0700, Andreas Dilger wrote:
> > From: Andreas Dilger <adilger@...ger.ca>
> > 
> > If an unknown flag is present in a FIEMAP extent, it is printed as a
> > hex value into a temporary buffer before adding it to the flags.  If
> > that unknown flag is over 0xffff then it will overflow the temporary
> > buffer.
> > 
> > Reported-by: Sarah Liu <wei3.liu@...el.com>
> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10335
> > Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
> 
> Looks ok,
> Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied with the 0xfff fixup in the commit description.

		     	       	     - Ted