linux-ext4 - Re: [PATCH 03/10] e2fsck: fix reading fscrypt_symlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 15:29:09 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-ext4@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH 03/10] e2fsck: fix reading fscrypt_symlink_data.len

On Fri, Mar 02, 2018 at 04:59:16PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The ciphertext length field stored at the beginning of encrypted symlink
> targets is 16-bit.  But e2fsck_pass1_check_symlink() is reading it as
> 32-bit.  This was apparently left over from an earlier on-disk format
> that was not merged.  Fix it.
> 
> This bug caused a small proportion of encrypted symlinks with 4092-byte
> targets to be considered invalid by e2fsck, but otherwise had no effect.
> 
> Fixes: 62ad24802c6e ("e2fsck: handle encrypted directories which are indexed using htree")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

						- Ted