linux-ext4 - Re: [PATCH 07/10] e2fsck: drop redundant checks of symlink i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Mar 2018 17:10:36 -0500
From:   Theodore Ts'o <tytso@....edu>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-ext4@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH 07/10] e2fsck: drop redundant checks of symlink i_size

On Fri, Mar 02, 2018 at 04:59:20PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> e2fsck_pass1_check_symlink() verifies that the symlink inode's i_size is
> less than the buffer length (60 for fast symlinks, fs->blocksize for
> slow symlinks).  But it also verifies that len == i_size &&
> len < buflen, which already implies i_size < buflen.  Thus, remove the
> redundant checks of i_size.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Applied, thanks.

				- Ted