linux-ext4 - Re: [PATCH 2/7] jbd2: clarify bad journal block checksum message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Mar 2018 17:51:10 +0100
From:   Jan Kara <jack@...e.cz>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 2/7] jbd2: clarify bad journal block checksum message

On Mon 19-02-18 21:30:33, Theodore Ts'o wrote:
> There were two error messages emitted by jbd2, one for a bad checksum
> for a jbd2 descriptor block, and one for a bad checksum for a jbd2
> data block.  Change the data block checksum error so that the two can
> be disambiguated.
> 
> Signed-off-by: Theodore Ts'o <tytso@....edu>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza


> ---
>  fs/jbd2/recovery.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
> index f99910b69c78..a4967b27ffb6 100644
> --- a/fs/jbd2/recovery.c
> +++ b/fs/jbd2/recovery.c
> @@ -600,8 +600,8 @@ static int do_one_pass(journal_t *journal,
>  						success = -EFSBADCRC;
>  						printk(KERN_ERR "JBD2: Invalid "
>  						       "checksum recovering "
> -						       "block %llu in log\n",
> -						       blocknr);
> +						       "data block %llu in "
> +						       "log\n", blocknr);
>  						block_error = 1;
>  						goto skip_write;
>  					}
> -- 
> 2.16.1.72.g5be1f00a9a
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR