linux-ext4 - Re: [PATCH 1/4] tune2fs: allow setting the filesystem error bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180309123104.i4y4djvtp2n6yltq@rh_laptop>
Date:   Fri, 9 Mar 2018 13:31:04 +0100
From:   Lukas Czerner <lczerner@...hat.com>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/4] tune2fs: allow setting the filesystem error bit

On Thu, Mar 08, 2018 at 12:13:21PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Allow the administrator to mark the filesystem's error bit to force a
> fsck at the next mount.

Looks good.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> ---
>  misc/tune2fs.8.in |    4 ++++
>  misc/tune2fs.c    |    5 +++++
>  2 files changed, 9 insertions(+)
> 
> 
> diff --git a/misc/tune2fs.8.in b/misc/tune2fs.8.in
> index 740d166..f1def2b 100644
> --- a/misc/tune2fs.8.in
> +++ b/misc/tune2fs.8.in
> @@ -238,6 +238,10 @@ program.
>  This superblock setting is only honored in 2.6.35+ kernels;
>  and not at all by the ext2 and ext3 file system drivers.
>  .TP
> +.B force_fsck
> +Set a flag in the filesystem superblock indicating that errors have been found.
> +This will force fsck to run at the next mount.
> +.TP
>  .B test_fs
>  Set a flag in the filesystem superblock indicating that it may be
>  mounted using experimental kernel code, such as the ext4dev filesystem.
> diff --git a/misc/tune2fs.c b/misc/tune2fs.c
> index 93160c9..ea84e1e 100644
> --- a/misc/tune2fs.c
> +++ b/misc/tune2fs.c
> @@ -2117,6 +2117,10 @@ static int parse_extended_opts(ext2_filsys fs, const char *opts)
>  			       intv);
>  			fs->super->s_mmp_update_interval = intv;
>  			ext2fs_mark_super_dirty(fs);
> +		} else if (!strcmp(token, "force_fsck")) {
> +			fs->super->s_state |= EXT2_ERROR_FS;
> +			printf(_("Setting filesystem error flag to force fsck.\n"));
> +			ext2fs_mark_super_dirty(fs);
>  		} else if (!strcmp(token, "test_fs")) {
>  			fs->super->s_flags |= EXT2_FLAGS_TEST_FILESYS;
>  			printf("Setting test filesystem flag\n");
> @@ -2199,6 +2203,7 @@ static int parse_extended_opts(ext2_filsys fs, const char *opts)
>  			"\tmmp_update_interval=<mmp update interval in seconds>\n"
>  			"\tstride=<RAID per-disk chunk size in blocks>\n"
>  			"\tstripe_width=<RAID stride*data disks in blocks>\n"
> +			"\tforce_fsck\n"
>  			"\ttest_fs\n"
>  			"\t^test_fs\n"));
>  		free(buf);
>