lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 10 Mar 2018 16:24:37 -0500
From:   "Theodore Y. Ts'o" <>
To:     Andreas Dilger <>
Cc:     Lukas Czerner <>,
Subject: Re: [PATCH] e2fsck: fix endianness problem when reading htree nodes

On Fri, Mar 09, 2018 at 12:12:04PM -0700, Andreas Dilger wrote:
> Rather than using 0xffffff directly, it makes sense to add something like:
>     #define EXT4_DX_BLOCK_MASK 0x0fffffff
> and use this in both the kernel and e2fsprogs?  I checked the rest of e2fsprogs
> and it looks like this is the only place where this mask is used.

Makes sense to me.  I'll apply this patch with this change.

Also, this mask is actually used in one more place, in

		blk = ext2fs_le32_to_cpu(ent[i].block) & 0x0ffffff;

I'll fix that up too.

						- Ted

Powered by blists - more mailing lists