linux-ext4 - Re: [PATCH 2/4] e2scrub: create online fsck tool of sorts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <42218B7E-31BA-4EDB-9470-015F69A56041@dilger.ca>
Date:   Wed, 14 Mar 2018 22:03:15 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     tytso@....edu, lczerner@...hat.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/4] e2scrub: create online fsck tool of sorts

On Mar 14, 2018, at 12:17 AM, Darrick J. Wong <darrick.wong@...cle.com> wrote:
> 
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Implement online fsck for ext* filesystems which live on LVM-managed
> logical volumes.  The basic strategy mirrors that of e2croncheck --
> create a snapshot, fsck the snapshot, report whatever errors appear,
> remove snapshot.  Unlike e2croncheck, this utility accepts any LVM
> device path, knows about snapshots running out of space, and can call
> fstrim having validated that the fs metadata is ok.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> diff --git a/scrub/e2scrub.in b/scrub/e2scrub.in
> new file mode 100644
> index 0000000..647f0e6
> --- /dev/null
> +++ b/scrub/e2scrub.in
> @@ -0,0 +1,207 @@
> +#!/bin/bash
> +
> +#  Copyright (C) 2018 Oracle.  All Rights Reserved.
> +#
> +#  Author: Darrick J. Wong <darrick.wong@...cle.com>
> +#
> +#  This program is free software; you can redistribute it and/or
> +#  modify it under the terms of the GNU General Public License
> +#  as published by the Free Software Foundation; either version 2
> +#  of the License, or (at your option) any later version.
> +#
> +#  This program is distributed in the hope that it would be useful,
> +#  but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#  GNU General Public License for more details.
> +#
> +#  You should have received a copy of the GNU General Public License
> +#  along with this program; if not, write the Free Software Foundation,
> +#  Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301, USA.

I think it is preferred to visit http://www.gnu.org/licenses/gpl-2.0.html
since this snail mail address has changed in the past, and it is unlikely
that anyone would use it in any case.

> +# Automatically check a LVM-managed filesystem online.
> +# We use lvm snapshots to do this, which means that we can only
> +# check filesystems in VGs that have at least 256mb (or so) of

s/mb/MB/

> +# Make sure this is an LVM device we can snapshot
> +lvm_vars="$(lvs --nameprefixes -o name,vgname,lv_role --noheadings "${dev}" 2> /dev/null)"
> +eval "${lvm_vars}"
> +if [ -z "${LVM2_VG_NAME}" ] || [ -z "${LVM2_LV_NAME}" ] ||
> +   echo "${LVM2_LV_ROLE}" | grep -q "snapshot"; then
> +	echo "${dev}: Not a LVM logical volume."
> +	print_help
> +	exit 16
> +fi
> +start_time="$(date +'%Y%m%d%H%M%S')"
> +snap="${LVM2_LV_NAME}.e2scrub"
> +snap_dev="/dev/${LVM2_VG_NAME}/${snap}"
> +
> +teardown() {
> +	# Remove and wait for removal to succeed.
> +	${DBG} lvremove -f "${LVM2_VG_NAME}/${snap}" 3>&-

It isn't clear to me what fd 3 is for in these commands?

> +	while [ -e "${snap_dev}" ] && [ "$?" -eq "5" ]; do
> +		sleep 0.5
> +		${DBG} lvremove -f "${LVM2_VG_NAME}/${snap}" 3>&-
> +	done

This while loop could be slightly restructured to avoid multiple lvremove
commands, like:

teardown() {
	# Remove and wait for removal to succeed.
	while [ -e "${snap_dev}" ] &&
	      [ `${DBG} lvremove -f "${LVM2_VG_NAME}/${snap}" 3>&-` -eq "5" ]; do
		sleep 0.5
	done
}

That said, should this fail after some number of retries?  What if there
is another e2scrub running on this device keeping it busy?  Should that
be checked separately?

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)