linux-ext4 - Re: [PATCH] libext2fs: fix ext2fs_open2() error for meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180317191412.GA4331@thunk.org>
Date:   Sat, 17 Mar 2018 15:14:12 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Kazuya Mio <k-mio@...jp.nec.com>
Cc:     "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] libext2fs: fix ext2fs_open2() error for meta_bg image
 file

On Wed, Mar 14, 2018 at 05:46:29AM +0000, Kazuya Mio wrote:
> dumpe2fs/debugfs can examine the image file by using the -i option.
> However, if meta_bg feature is enabled, dumpe2fs/debugfs cannot open
> the image file.
> 
> $ dumpe2fs -i test.img
> dumpe2fs: Attempt to read block from filesystem resulted in short read while trying to open test.img
> Couldn't find valid filesystem superblock.
> 
> In case of specifying an image file, the location of block group descriptors
> is the same as the case of default filesystem regardless of meta_bg feature.
> So if EXT2_FLAG_IMAGE_FILE flag is set in ext2fs_open2(),
> don't use the meta_bg handling.
> 
> Signed-off-by: Kazuya Mio <k-mio@...jp.nec.com>

Applied, thanks!!

					- Ted